Fix gcs init args wrapping when ConsolePipe is enabled #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCS init fails to parse the entropy socket when enabling ConsolePipe. Fix by separating entropy parameters from the rest init args and wrapping only init args with `sh -c`. Signed-off-by: Maksim An <maksiman@microsoft.com>
|
Looks like this changes from
to
is that right? |
dcantah
approved these changes
Mar 21, 2022
|
Why does github keep posting everything I comment twice... |
yup. |
helsaawy
approved these changes
Mar 22, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
GCS init fails to parse the entropy socket when enabling ConsolePipe. Fix by separating entropy parameters from the rest init args and wrapping only init args with `sh -c`. Changes: `/init sh -c "-e 1 /bin/vsockexec -e 109 /bin/gcs -v4 -log-format json -loglevel debug & exec sh"` to `/init -e 1 sh -c "/bin/vsockexec -e 109 /bin/gcs -v4 -log-format json -loglevel debug & exec sh"` Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCS init fails to parse the entropy socket when enabling ConsolePipe.
Fix by separating entropy parameters from the rest init args and
wrapping only init args with
sh -c.Signed-off-by: Maksim An maksiman@microsoft.com