Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootfs.vhd make target #1333

Merged
merged 1 commit into from
Mar 22, 2022
Merged

rootfs.vhd make target #1333

merged 1 commit into from
Mar 22, 2022

Conversation

helsaawy
Copy link
Contributor

New makefile target to create rootfs.vhd from rootfs.tar using tar2ext4.
Requires building cmd/tar2ext4 locally.

Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com

@helsaawy helsaawy requested a review from a team as a code owner March 19, 2022 03:19
dcantah
dcantah approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth having this be part of the default goal, can't think of why we wouldn't want to always build this as it's the default if it exists.

@dcantah
Copy link
Contributor

dcantah commented Mar 22, 2022

Oop this needs a rebase after 51aee6b

@helsaawy
Copy link
Contributor Author

Maybe it's worth having this be part of the default goal, can't think of why we wouldn't want to always build this as it's the default if it exists.

I think this line gzip -f -d ./out/rootfs.tar.gz consumes the tar.gz file, so running it by default would crash all the pipelines that expect to build the rootfs manually

@helsaawy
rootfs make target
3b2f20a 
New makefile target to create rootfs.vhd from rootfs.tar using tar2ext4.
Requires building cmd/tar2ext4 locally.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy merged commit 7adccbb into microsoft:master Mar 22, 2022
@helsaawy helsaawy deleted the he/rootfsmake branch March 22, 2022 15:35
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
@ambarve
Merged PR 5895108: update ADO to d36cc7c
6a5be6f 
Related work items: #1240, #1241, #1258, #1260, #1270, #1271, #1272, #1279, #1286, #1288, #1289, #1292, #1293, #1294, #1295, #1297, #1298, #1299, #1301, #1305, #1307, #1308, #1309, #1310, #1313, #1314, #1315, #1318, #1320, #1321, #1322, #1324, #1326, #1328, #1332, #1333, #1334, #1335, #1337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiewasnothere katiewasnothere katiewasnothere approved these changes

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helsaawy @dcantah @katiewasnothere