Cleanup 'getUserTokenInheritAnnotation' #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function used to just return a bool of whether the annotation was "true" or not which is a bit diffferent than what the name implied. Change to inheritUserTokenIsSet to be more clear. It also used to check if the annotation was set internally which shouldn't be needed as we only cared about whether it was "true" or not. If the value isn't in the map we should just get back the default value of a string which is fine for what it was being used for. Additionally moves a comment that was mistakingly directly above the function body to the top of the file. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
helsaawy
approved these changes
Feb 11, 2022
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This function used to just return a bool of whether the annotation was "true" or not which is a bit diffferent than what the name implied. Change to inheritUserTokenIsSet to be more clear. It also used to check if the annotation was set internally which shouldn't be needed as we only cared about whether it was "true" or not. If the value isn't in the map we should just get back the default value of a string which is fine for what it was being used for. Additionally moves a comment that was mistakingly directly above the function body to the top of the file. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function used to just return a bool of whether the annotation was "true"
or not which is a bit diffferent than what the name implied. Change to inheritUserTokenIsSet
to be more clear. It also used to check if the annotation was set internally which
shouldn't be needed as we only cared about whether it was "true" or not. If the
value isn't in the map we should just get back the default value of a string which
is fine for what it was being used for.
Additionally moves a comment that was mistakingly directly above the function body
to the top of the file.