Clarifying SVN vs. Version. #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates `framework_svn` and `api_svn` to be named `framework_version` and `api_version`, respectively. The original names were to represent a *semantic* version number, which was confusing in this context where SVN more commonly means *security* version number. Accordingly, the `minimum_svn` and `svn` fields for fragments will remain with the existing naming scheme but their support has been expanded to allow these strings to also be monotonically increasing integers, to be more in line with expectations around SVNs. To provide a smooth transition, support for semantically versioned fragments and the `*_svn` naming scheme remain in the framework, but in a deprecated state. As part of this, the policy engline will provide a new error when the type of SVN is different between the SVN of the fragment and the `minimum_svn` property of a fragment policy object: `fragment svn and the specified minimum are different types`. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
matajoh
force-pushed
the
svn-version-cleanup
branch
from
d8886a4
to
11bc9d9
Compare
helsaawy
approved these changes
Mar 30, 2023
anmaxvl
approved these changes
Mar 31, 2023
takuro-sato
pushed a commit
to takuro-sato/hcsshim
that referenced
this pull request
Apr 25, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
framework_svnandapi_svnto be namedframework_versionandapi_version, respectively. The original names were to represent a semantic version number, which was confusing in this context where SVN more commonly means security version number. Accordingly, theminimum_svnandsvnfields for fragments will remain with the existing naming scheme but their support has been expanded to allow these strings to also be monotonically increasing integers, to be more in line with expectations around SVNs.To provide a smooth transition, support for semantically versioned fragments and the
*_svnnaming scheme remain in the framework, but in a deprecated state. As part of this, the policy engline will provide a new error when the type of SVN is different between the SVN of the fragment and theminimum_svnproperty of a fragment policy object:fragment svn and the specified minimum are different types.