Add Close/WaitCtx to UtilityVM & System #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
force-pushed
the
uvm-wait-context
branch
from
2272964
to
6c34b04
Compare
helsaawy
force-pushed
the
uvm-wait-context
branch
from
6c34b04
to
5758c44
Compare
kevpar
reviewed
Oct 19, 2023
kevpar
reviewed
Oct 19, 2023
ambarve
reviewed
Oct 20, 2023
ambarve
reviewed
Oct 23, 2023
ambarve
reviewed
Oct 23, 2023
test/internal/util/util.go
Outdated
| @@ -18,3 +21,26 @@ func CleanName(n string) string { | |||
| } | |||
| return strings.TrimSpace(strings.Map(mapper, n)) | |||
| } | |||
|
|
|||
| // RandNameSuffix concants the provided paramters and appends a random 4 byte sequence as as hex string. | |||
There was a problem hiding this comment.
nits:
*concats,
as as,
*This is to ensure
ambarve
approved these changes
Oct 23, 2023
helsaawy
force-pushed
the
uvm-wait-context
branch
from
458f81b
to
201f298
Compare
Add `CloseCtx` and `WaitCtx` methods to `UtilityVM` and `System`, which accept a context parameter and return if the context is canceled. This is intended to allow benchmark iterations to time out and prevent them from spending the majority of their time waiting. However, the added benefit is that tracing information (trace and span ID) will now be passed along to the `Wait` and `Close` logs (and underlying HCS call spans). Additionally, fix a bug in `(*UtilityVM).Close`, where, if the uVM was created but not started, then the `(*UtilityVM).Wait` call will hang indefinitely. Fix is to wait initially on the system to close, close the IO output handler, and then wait on the uVM. Combine LCOW uVM benchmarks together (similar to LCOW container) to simplify benchmark name formatting. Relies on microsoft#1875 Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
uvm-wait-context
branch
from
201f298
to
3bf8214
Compare
darracott
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
Oct 30, 2023
* Add `Close`/`WaitCtx` to `UtilityVM` & `System` Add `CloseCtx` and `WaitCtx` methods to `UtilityVM` and `System`, which accept a context parameter and return if the context is canceled. This is intended to allow benchmark iterations to time out and prevent them from spending the majority of their time waiting. However, the added benefit is that tracing information (trace and span ID) will now be passed along to the `Wait` and `Close` logs (and underlying HCS call spans). Additionally, fix a bug in `(*UtilityVM).Close`, where, if the uVM was created but not started, then the `(*UtilityVM).Wait` call will hang indefinitely. Fix is to wait initially on the system to close, close the IO output handler, and then wait on the uVM. Combine LCOW uVM benchmarks together (similar to LCOW container) to simplify benchmark name formatting. Relies on microsoft#1875 Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> * PR: uvm.Wait err handling; doc comments Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> --------- Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Joe Powell <joepowell@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Add `Close`/`WaitCtx` to `UtilityVM` & `System` Add `CloseCtx` and `WaitCtx` methods to `UtilityVM` and `System`, which accept a context parameter and return if the context is canceled. This is intended to allow benchmark iterations to time out and prevent them from spending the majority of their time waiting. However, the added benefit is that tracing information (trace and span ID) will now be passed along to the `Wait` and `Close` logs (and underlying HCS call spans). Additionally, fix a bug in `(*UtilityVM).Close`, where, if the uVM was created but not started, then the `(*UtilityVM).Wait` call will hang indefinitely. Fix is to wait initially on the system to close, close the IO output handler, and then wait on the uVM. Combine LCOW uVM benchmarks together (similar to LCOW container) to simplify benchmark name formatting. Relies on microsoft#1875 Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> * PR: uvm.Wait err handling; doc comments Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> --------- Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CloseCtxandWaitCtxmethods toUtilityVMandSystem, which accept a context parameter and return if the context is canceled.This is intended to allow benchmark iterations to time out and prevent them from spending the majority of their time waiting.
However, the added benefit is that tracing information (trace and span ID) will now be passed along to the
WaitandCloselogs (and underlying HCS call spans).Additionally, fix a bug in
(*UtilityVM).Close, where, if the uVM was created but not started, then the(*UtilityVM).Waitcall willhang indefinitely.
Fix is to wait initially on the system to close, close the IO output
handler, and then wait on the uVM.
Combine LCOW uVM benchmarks together (similar to LCOW container) to simplify benchmark name formatting.