Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close/WaitCtx to UtilityVM & System #1876

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add Close/WaitCtx to UtilityVM & System #1876

merged 2 commits into from
Oct 24, 2023

Commits on Oct 24, 2023

  1. Add Close/WaitCtx to UtilityVM & System 

    Add `CloseCtx` and `WaitCtx` methods to `UtilityVM` and `System`, which
accept a context parameter and return if the context is canceled.

This is intended to allow benchmark iterations to time out and prevent
them from spending the majority of their time waiting.

However, the added benefit is that tracing information (trace and span
ID) will now be passed along to the `Wait` and `Close` logs (and
underlying HCS call spans).

Additionally, fix a bug in `(*UtilityVM).Close`, where, if the uVM was
created but not started, then the `(*UtilityVM).Wait` call will
hang indefinitely.
Fix is to wait initially on the system to close, close the IO output
handler, and then wait on the uVM.

Combine LCOW uVM benchmarks together (similar to LCOW container) to
simplify benchmark name formatting.

Relies on microsoft#1875

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    @helsaawy
    helsaawy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    badea6e View commit details
    Browse the repository at this point in the history

  2. PR: uvm.Wait err handling; doc comments 

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    @helsaawy
    helsaawy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3bf8214 View commit details
    Browse the repository at this point in the history