Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes to force LF line endings #914

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

dcantah
Copy link
Contributor

@dcantah dcantah commented Dec 17, 2020

Signed-off-by: Daniel Canter dcanter@microsoft.com

@dcantah dcantah requested a review from a team as a code owner December 17, 2020 22:36
@kevpar
Copy link
Member

kevpar commented Dec 17, 2020

Shouldn't this change have also marked cpu_group_operations.go as modified, since it would be normalized now?

@dcantah
Copy link
Contributor Author

dcantah commented Dec 17, 2020

@kevpar You'd think so... Let me see

@dcantah
Copy link
Contributor Author

dcantah commented Dec 17, 2020

It only changes things added so I had to explicitly add it.

@dcantah
Copy link
Contributor Author

dcantah commented Dec 17, 2020

You want me to do a run and convert everything that might be crlf?

@kevpar
Copy link
Member

kevpar commented Dec 17, 2020

You want me to do a run and convert everything that might be crlf?

Not sure what you mean by a run, but we should check if anything else needs to be converted to LF.

@dcantah
Copy link
Contributor Author

dcantah commented Dec 17, 2020

@kevpar Wasn't related to anything in specific, sorry for the confusion

Was just going to do:

find . -type f -exec dos2unix {} \;

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants