Skip unmounting layers for sandbox container. #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
special-case-scratch
branch
2 times, most recently
from
d36e24c to
b8e5f80
Compare
internal/hcsoci/create.go
Outdated
| @@ -145,6 +146,7 @@ func CreateContainer(ctx context.Context, createOptions *CreateOptions) (_ cow.C | |||
| if err != nil { | |||
| return nil, r, err | |||
| } | |||
| isSandbox = ct == oci.KubernetesContainerTypeSandbox | |||
There was a problem hiding this comment.
Shouldn't this be moved out of the networking setup code path?
There was a problem hiding this comment.
Sure, now that it's used for more than just network setup
dcantah
force-pushed
the
special-case-scratch
branch
from
b8e5f80 to
d221e81
Compare
internal/hcsoci/create.go
Outdated
| @@ -285,13 +281,17 @@ func CreateContainer(ctx context.Context, createOptions *CreateOptions) (_ cow.C | |||
| } | |||
|
|
|||
| // Create a network namespace if necessary. | |||
There was a problem hiding this comment.
Nit: this should go under the code for getting the container type........
* Skip unmounting the layers for the sandbox container as we know the UVM gets torn down shortly afterwards. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
special-case-scratch
branch
from
d221e81 to
61e1b43
Compare
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
Related work items: microsoft#173, microsoft#839, microsoft#856, microsoft#877, microsoft#881, microsoft#886, microsoft#887, microsoft#888, microsoft#889, microsoft#890, microsoft#893, microsoft#894, microsoft#896, microsoft#899, microsoft#900, microsoft#902, microsoft#904, microsoft#905, microsoft#906, microsoft#907, microsoft#908, microsoft#910, microsoft#912, microsoft#913, microsoft#914, microsoft#916, microsoft#918, microsoft#923, microsoft#925, microsoft#926, microsoft#928, microsoft#929, microsoft#932, microsoft#933, microsoft#934, microsoft#938, microsoft#939, microsoft#942, microsoft#943, microsoft#945, microsoft#946, microsoft#947, microsoft#949, microsoft#951, microsoft#952, microsoft#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Canter dcanter@microsoft.com