Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the maint/maint-67 to 67.1.0.2 for the Taiwan calendar changes #12

Merged
merged 4 commits into from
Jul 28, 2020

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Jul 28, 2020

Summary

This change merges the Taiwan calendar changes (PR #8) and the runtime Nuget changes (PR #9) into the maint/maint-67 branch.

The version number has been bumped to 67.1.0.2 for these changes.

Note: To preserve the history of the commits, this change will need to be merged as a "merge commit", rather than the usual squash merge approach.

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

erik0686 and others added 4 commits July 21, 2020 13:02
…other DLLs and EXEs (#9)

This change makes a number of changes to the Nuget build scripts and configuration for MS-ICU.

It removes the all-in-one Nuget package approach that was used previously, and instead now uses a meta-package with dependencies. These dependent packages contain architecture specific DLLs, which can be built separately from the main meta-package.

The name of the package is changed to "Microsoft.ICU.icu4c.runtime" to reflect that it only contains the 'common' and 'i18n' code libraries from ICU4C, along with the data DLL. No other binaries are included in the package. (Ex: the ICU tools or the IO library).
The headers and libs/pdbs are also omitted as well, in order to make the "runtime" package as small as possible.
@jefgen jefgen requested review from erik0686, axelandrejs, daniel-ju and a team July 28, 2020 01:10
@jefgen jefgen merged commit dca5db8 into maint/maint-67 Jul 28, 2020
@jefgen jefgen deleted the user/jefgen/merge-67.1.0.2-to-maint-67 branch July 28, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants