Nuget package changes: Use a meta-package, rename to runtime, remove other DLLs and EXEs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-ju
reviewed
Jul 24, 2020
daniel-ju
reviewed
Jul 24, 2020
daniel-ju
approved these changes
Jul 24, 2020
axelandrejs
approved these changes
Jul 24, 2020
5 tasks
jefgen
added a commit
that referenced
this pull request
Jul 28, 2020
This change merges the Taiwan calendar changes (PR #8) and the runtime Nuget changes (PR #9) into the maint/maint-67 branch. The version number has been bumped to 67.1.0.2 for these changes. Note: To preserve the history of the commits, this change will need to be merged as a "merge commit", rather than the usual squash merge approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a number of changes to the Nuget build scripts and configuration for MS-ICU.
It removes the all-in-one Nuget package approach that was used previously, and instead now uses a meta-package with dependencies. These dependent packages contain architecture specific DLLs, which can be built separately from the main meta-package.
The name of the package is changed to "
Microsoft.ICU.icu4c.runtime" to reflect that it only contains the 'common' and 'i18n' code libraries from ICU4C, along with the data DLL. No other binaries are included in the package. (Ex: the ICU tools or the IO library).The headers and libs/pdbs are also omitted as well, in order to make the "runtime" package as small as possible.
PR Checklist