Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http - implement body inspection handler #482

Closed
baywet opened this issue Dec 2, 2024 · 4 comments · Fixed by #493
Closed

http - implement body inspection handler #482

baywet opened this issue Dec 2, 2024 · 4 comments · Fixed by #493
Assignees
Labels
enhancement New feature or request help wanted Standard GitHub label type:enhancement Enhancement request targeting an existing experience WIP

Comments

@baywet
Copy link
Member

baywet commented Dec 2, 2024

specification microsoftgraph/msgraph-sdk-design#116
make sure you update the documentation as well

@msgraph-bot msgraph-bot bot added this to Kiota Dec 2, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Dec 2, 2024
@baywet baywet added enhancement New feature or request type:enhancement Enhancement request targeting an existing experience help wanted Standard GitHub label labels Dec 2, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Dec 2, 2024
@marcinjahn
Copy link
Contributor

Let me take a stab at it and see what I can do

@AndrewZenith
Copy link

Hi, I've been using Kiota in C# now for talking to HMRC Services in the UK. However, they are aaplication/xml content instead of json. So, even though responses are (or can be) in the OpenApi yaml file, nothing is generated to get them.
It all works returning a stream of the content when an OK(200) is received.

I'm thinking this issue may solve my problem from the looks of it? If I can get the status code and body content then I can handle myself.

@baywet
Copy link
Member Author

baywet commented Dec 6, 2024

@AndrewZenith if the xml structure is described with a JSON schema, you'll get a much better experience by:

  1. implementing IParseNode and ISerializationWriter (+ factories) for XML.
  2. using the structured mime types during generation
  3. registering the new factories at runtime, so XML can be serialized/deserialized

Arguably it's a bit more work though.

And if you're willing to, you could even stand up a new project/package under the kiota community organization, so others can also use the XML implementation.

marcinjahn added a commit to marcinjahn/kiota-dotnet that referenced this issue Dec 7, 2024
@AndrewZenith
Copy link

Arguably it's a bit more work though.

100+ classes for just one of the many responses. I have the xsd's though.

@baywet baywet closed this as completed in 3bc8cbd Dec 13, 2024
@github-project-automation github-project-automation bot moved this from New📃 to Done ✔️ in Kiota Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Standard GitHub label type:enhancement Enhancement request targeting an existing experience WIP
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants