Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BodyInspectionHandler #493

Merged
merged 11 commits into from
Dec 13, 2024

Conversation

marcinjahn
Copy link
Contributor

@marcinjahn marcinjahn commented Dec 7, 2024

Closes #482

Docs updates done via MicrosoftDocs/openapi-docs#140.

@marcinjahn marcinjahn force-pushed the bodyinspectionhandler-482 branch from 74da9ca to 3c5023a Compare December 7, 2024 20:44
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @marcinjahn

Any chance you can also run dotnet format command from the project root to resolve the linting errors?

@marcinjahn marcinjahn force-pushed the bodyinspectionhandler-482 branch from e5f910f to 4fd91fc Compare December 9, 2024 17:43
@marcinjahn
Copy link
Contributor Author

Thanks for the contribution here @marcinjahn

Any chance you can also run dotnet format command from the project root to resolve the linting errors?

I pushed dotnet formatted code now

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

src/http/httpClient/Middleware/BodyInspectionHandler.cs Outdated Show resolved Hide resolved
@marcinjahn marcinjahn requested a review from baywet December 12, 2024 12:21
baywet
baywet previously approved these changes Dec 12, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@andrueastman for final review and merge

@marcinjahn
Copy link
Contributor Author

marcinjahn commented Dec 12, 2024

@baywet @andrueastman Please have a look, I simplified it just a little bit. The RequestStream and ResponseStream are no longer nullable, they're Stream.Null by default, and this is also the value being returned anytime there is no content in request/response. Previously, I'd return null or Stream.Null and probably it doens't make sense to do that, especially since it was not documented when each one gets returned.

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @marcinjahn. Looks good from my end.

@baywet Any chance you can do a final review of the latest changes as well before merge?

@baywet baywet merged commit 3bc8cbd into microsoft:main Dec 13, 2024
7 checks passed
@marcinjahn marcinjahn deleted the bodyinspectionhandler-482 branch December 13, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

http - implement body inspection handler
3 participants