Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary @Nullable annotations #1149

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Remove unnecessary @Nullable annotations #1149

merged 4 commits into from
Apr 3, 2024

Conversation

piotrooo
Copy link
Contributor

@piotrooo piotrooo commented Apr 2, 2024

Closes #1145

@piotrooo
Copy link
Contributor Author

piotrooo commented Apr 2, 2024

@microsoft-github-policy-service agree

andrueastman
andrueastman reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can also add a entry to the changelog file at the root of the repositoy as well?

@andrueastman andrueastman enabled auto-merge April 3, 2024 10:38
andrueastman
andrueastman approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @piotrooo

@andrueastman andrueastman merged commit a7a6569 into microsoft:main Apr 3, 2024
8 checks passed
@piotrooo piotrooo deleted the feature/remove-nullable-from-base-request-configuration branch April 3, 2024 10:53
@baywet baywet mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet Awaiting requested review from baywet

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request headers shouldn't be @Nullable
2 participants
@piotrooo @andrueastman