Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary @Nullable annotations #1149

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Remove unnecessary @Nullable annotations #1149

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cf3a97
Remove unnecessary @Nullable annotations
piotrooo Apr 2, 2024
590f8a3
Add @Nonnull annotation
piotrooo Apr 3, 2024
f346318
Add changelog entry
piotrooo Apr 3, 2024
fbbcf04
Merge branch 'main' into feature/remove-nullable-from-base-request-co…
piotrooo Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions components/abstractions/src/main/java/com/microsoft/kiota/BaseRequestConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.microsoft.kiota;

import jakarta.annotation.Nullable;

import java.util.Collections;
import java.util.List;

/** Base class for request configuration */
/**
* Base class for request configuration
*/
public abstract class BaseRequestConfiguration {
/**
* Default constructor
Expand All @@ -13,9 +14,13 @@ public BaseRequestConfiguration() {
// default empty constructor
}

/** Request headers */
@Nullable public RequestHeaders headers = new RequestHeaders();
/**
* Request headers
*/
public RequestHeaders headers = new RequestHeaders();
andrueastman marked this conversation as resolved.
Show resolved Hide resolved

/** Request options */
@Nullable public java.util.List<RequestOption> options = Collections.emptyList();
/**
* Request options
*/
public List<RequestOption> options = Collections.emptyList();
}
Loading