[VS Code] Sign-in failed.

[AjkayAlan]

Error:

Sign-in failed.

Steps to Reproduce:

1. Click sign in on bottom left hand corner. A chrome window pops up
2. Sign in to my account
3. Approve permissions that are requested

The call back from https://insiders.liveshare.vsengsaas.visualstudio.com/auth/identity/microsoft/callback appears and then VS Code just throws the sign in error

	Version Data
extensionName	VSLS
extensionVersion	0.2.163
protocolVersion	2.1
applicationName	VSCode
applicationVersion	1.20.1
platformName	Windows
platformVersion	10.0.14393

Extra factors that may be contributing to this

• I have a system wide http and https proxy I have to use (due to corporate restrictions)

[AjkayAlan]

Recommended labels:
os: windows
vscode
area: identity and sign-in

[Chuxel]

@AjkayAlan Thanks for reporting this. A few questions:

1. What error do you see?
2. As a workaround, if you click "Having trouble?" in the chrome page after signing in and follow the instructions to log in using a user code does it work?
3. Could you repro and attach your logs (or email them to vsls-feedback@microsoft.com)? You can get a zip of them by running the "Live Share: Export Logs" command in VS Code.

[AjkayAlan]

Hey @Chuxel!

The error I see is a super generic error which just states "Error: Sign-in failed.".

I attempted using the workaround with "Having trouble" and using a user code, and got the same error. I reproduced them and sent an email as requested with the logs attached.

One tricky thing may be that I technically have 2 accounts under my sign up email address - one which was a personal one created a few years ago, and then one which is an organization managed one from Azure AD/SAML Auth. I attempted to login with both those accounts and had the same result. I used chrome for my person account, and Edge for my organization account.

[Chuxel]

@AjkayAlan Strange - This might be a variation of #86. @jasongin @anvan Here's the line in the logs of interest:

[2018-03-02 16:26:23.826 Agent.Http E] > POST https://insiders.liveshare.vsengsaas.visualstudio.com/auth/token (c32ms sms) => 407 authenticationrequired

[jasongin]

@Chuxel I think you're probably right.

@AjkayAlan Does your environment require use of an authenticating proxy server to access the internet? As described in #86, we have a known issue now where some parts of Live Share don't pick up the proxy settings. It's being worked on.

[AjkayAlan]

@jasongin and @Chuxel I think we are on the right track. I connected to a hotspot I have (bypassing our corporate firewall and proxy) and was able to sign in and share to someone else that was on the same hotspot.

Our environment does use an authenticating proxy server to access internet, but it is not required (essentially it allows us to get past normal firewall rules that block non-developers). I tried changing my connection mode to direct as defined in the issue and at https://github.com/MicrosoftDocs/live-share/blob/master/docs/getting-started.md#changing-the-connection-mode but still was not able to even sign in.

Since this issue is so similar to the other one, lets focus on #86 and I will reopen my issue if it is still present after #86 is fixed.

Thanks!