Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing BASECORE overrides for unit test include file #370

Merged
merged 2 commits into from
Apr 22, 2023
Merged

Removing BASECORE overrides for unit test include file #370

merged 2 commits into from
Apr 22, 2023

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Apr 21, 2023 •
edited
Loading

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

This change reverts the override added in the UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc from #354 and impacted package from #357. The impacted consumer should have included their own fixes, thus removing this change to prevent more debts collected in BASECORE.

Fixes #356

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This is unit test include file change. Tested on proprietary consumer packages.

Integration Instructions

N/A

@kuqin12 kuqin12 requested review from makubacki and os-d April 21, 2023 23:28
@github-actions github-actions bot added the impact:testing Affects testing label Apr 21, 2023
@kuqin12 kuqin12 requested a review from apop5 April 22, 2023 00:09
@kuqin12 kuqin12 merged commit d812d01 into microsoft:release/202208 Apr 22, 2023
@kuqin12 kuqin12 deleted the fix_356 branch April 22, 2023 02:41
@ProjectMuBot ProjectMuBot mentioned this pull request Apr 26, 2023
Merged
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 26, 2023
@ProjectMuBot
Bumps MU_BASECORE from 2022080001.2.1 to 2022080001.2.2
18a7cfa 
Introduces 4 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_basecore/commit/a5bf121fa89e0e65c0edfafac6eee88777214eda">a5bf12</a> Additional CodeQL Fixes (<a href="https://github.com/microsoft/mu_basecore/pull/358">#358</a>)</li>
<li><a href="https://github.com/microsoft/mu_basecore/commit/85cfafd87dbe6724e4d8c5419a249a71c51d754e">85cfaf</a> Handling the continue cases for BDS retry (<a href="https://github.com/microsoft/mu_basecore/pull/367">#367</a>)</li>
<li><a href="https://github.com/microsoft/mu_basecore/commit/d812d01ab5783c2119e1a47424b327e66b7dd442">d812d0</a> Removing BASECORE overrides for unit test include file (<a href="https://github.com/microsoft/mu_basecore/pull/370">#370</a>)</li>
<li><a href="https://github.com/microsoft/mu_basecore/commit/6bc15eef159bb4605e8a9419bb1fa60a1ae451a5">6bc15e</a> Repo File Sync: Update to Mu DevOps 2.4.0 (<a href="https://github.com/microsoft/mu_basecore/pull/366">#366</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
makubacki referenced this pull request in microsoft/mu_tiano_platforms Apr 26, 2023
@ProjectMuBot
Bump MU_BASECORE from 2022080001.2.1 to 2022080001.2.2 (#521)
da7a854 
Bumps MU_BASECORE from `2022080001.2.1` to `2022080001.2.2`

Introduces 4 new commits in
[MU_BASECORE](https://github.com/microsoft/mu_basecore.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_basecore/commit/a5bf121fa89e0e65c0edfafac6eee88777214eda">a5bf12</a>
Additional CodeQL Fixes (<a
href="https://github.com/microsoft/mu_basecore/pull/358">#358</a>)</li>
<li><a
href="https://github.com/microsoft/mu_basecore/commit/85cfafd87dbe6724e4d8c5419a249a71c51d754e">85cfaf</a>
Handling the continue cases for BDS retry (<a
href="https://github.com/microsoft/mu_basecore/pull/367">#367</a>)</li>
<li><a
href="https://github.com/microsoft/mu_basecore/commit/d812d01ab5783c2119e1a47424b327e66b7dd442">d812d0</a>
Removing BASECORE overrides for unit test include file (<a
href="https://github.com/microsoft/mu_basecore/pull/370">#370</a>)</li>
<li><a
href="https://github.com/microsoft/mu_basecore/commit/6bc15eef159bb4605e8a9419bb1fa60a1ae451a5">6bc15e</a>
Repo File Sync: Update to Mu DevOps 2.4.0 (<a
href="https://github.com/microsoft/mu_basecore/pull/366">#366</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
TaylorBeebe pushed a commit to TaylorBeebe/mu_basecore that referenced this pull request Apr 27, 2023
@kuqin12 @TaylorBeebe
Removing BASECORE overrides for unit test include file (microsoft#370)
cdd781e 
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

This change reverts the override added in the
`UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc` from
microsoft#354 and impacted package
from microsoft#357. The impacted
consumer should have included their own fixes, thus removing this change
to prevent more debts collected in BASECORE.

Fixes microsoft#356

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [x] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This is unit test include file change. Tested on proprietary consumer
packages.

## Integration Instructions

N/A
kenlautner pushed a commit that referenced this pull request Apr 28, 2023
@kuqin12 @kenlautner
Removing BASECORE overrides for unit test include file (#370)
4b468fd 
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

This change reverts the override added in the
`UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc` from
#354 and impacted package
from #357. The impacted
consumer should have included their own fixes, thus removing this change
to prevent more debts collected in BASECORE.

Fixes #356

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [x] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This is unit test include file change. Tested on proprietary consumer
packages.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apop5 apop5 apop5 approved these changes

@makubacki makubacki makubacki approved these changes

@os-d os-d Awaiting requested review from os-d

Assignees
No one assigned
Labels
impact:testing Affects testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Having to carry override in the unit test dsc
3 participants
@kuqin12 @makubacki @apop5