Remove UefiBootServicesTableLib from inclusion file

[kuqin12]

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

The inclusion file change will potentially change the library linkage of UefiBootServicesTableLib, which could be an incompatible instance compared to the existing consumers.

This change temporarily removes this inclusion until all unit tests from the consumers migrated their unit tests to the common implementation.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

• Impacts functionality?
  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...
• Impacts security?
  • Security - Does the change have a direct security impact on an application,
    flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
• Breaking change?
  • Breaking change - Will anyone consuming this change experience a break
    in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
• Includes tests?
  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...
• Includes documentation?
  • Documentation - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

This was tested on consumer packages that uses UefiBootServicesTableLib.

Integration Instructions

For packages uses UefiBootServicesTableLib|UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestUefiBootServicesTableLib.inf for unit tests, one needs to update the host test dsc to include the entry. Otherwise, no changes needed.

[makubacki]

Library instances in include files are typically meant to be included at the top of a DSC and overridden as needed by the package. Is that a problem here?

[kuqin12]

Library instances in include files are typically meant to be included at the top of a DSC and overridden as needed by the package. Is that a problem here?

The issue is that if the include file is more specific of a type than the end consumer, the more specific instance will supersede. For this case, the consuming dscs just have [LibraryClasses] for the UefiBootServicesLib

[makubacki]

Library instances in include files are typically meant to be included at the top of a DSC and overridden as needed by the package. Is that a problem here?

The issue is that if the include file is more specific of a type than the end consumer, the more

Library instances in include files are typically meant to be included at the top of a DSC and overridden as needed by the package. Is that a problem here?

The issue is that if the include file is more specific of a type than the end consumer, the more specific instance will supersede. For this case, the consuming dscs just have [LibraryClasses] for the UefiBootServicesLib

We can make the change but some notes:

1. UnitTestFrameworkPkgHost.dsc.inc has several common library classes assigned to instances (e.g. BaseLib, DebugLib, CpuLib, etc.) in [LibraryClasses.common.HOST_APPLICATION] so those would also be a problem if the platform wanted to override them.
2. The platform should be aware of that the include DSC specifies its library class instances in [LibraryClasses.common.HOST_APPLICATION] and specify libraries for that module type in a module-specific section to prevent future occurrences of this (new library instances being added to the DSC include file they don't override).
3. We should reduce Mu deltas and get back to parity with edk2 when possible.

[kuqin12]

Library instances in include files are typically meant to be included at the top of a DSC and overridden as needed by the package. Is that a problem here?

The issue is that if the include file is more specific of a type than the end consumer, the more specific instance will supersede. For this case, the consuming dscs just have [LibraryClasses] for the UefiBootServicesLib

Agreed. An issue is logged here: #356. Will remove this deviation after resolving the consuming dsc issues.