Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PcdIpmiBmcReadyDelayTimer Eligible for Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator) #171

Merged

Conversation

MarcChen46
Copy link
Contributor

@MarcChen46 MarcChen46 commented Oct 16, 2023

Description

Change PcdIpmiBmcReadyDelayTimer to Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Verified build and host-based unit test.

Integration Instructions

N/A

…ted in C code based

on different scenarios. (ex:Normal, BMC absence, Emulator)
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Oct 16, 2023
@apop5 apop5 requested review from cfernald and apop5 October 16, 2023 15:01
@makubacki makubacki added the type:design-change A new proposal or modification to a feature design label Oct 16, 2023
@MarcChen46 MarcChen46 changed the title Change PcdIpmiBmcReadyDelayTimer to Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator) Make PcdIpmiBmcReadyDelayTimer Eligible for Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator) Oct 16, 2023
@apop5
Copy link
Contributor

apop5 commented Oct 17, 2023

For clarity, this change brings the pcd into compatibility for platforms that make use of the edk2-platform's features/outofbandmanagement/ipmipkg pcd.

This was encountered in a platforms' code, and the mu version was not compatible prior to this change.

@apop5 apop5 enabled auto-merge (squash) October 17, 2023 01:20
@apop5 apop5 merged commit 6571f62 into microsoft:main Oct 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:design-change A new proposal or modification to a feature design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants