Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PcdIpmiBmcReadyDelayTimer Eligible for Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator) #171

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Make PcdIpmiBmcReadyDelayTimer Eligible for Dynamic PCD since it may get updated in C code based on different scenarios. (ex:Normal, BMC absence, Emulator) #171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755885d
Change PcdIpmiBmcReadyDelayTimer to Dynamic PCD since it may get upda…
MarcChen46 Oct 16, 2023
624870e
add a blank line at end of file.
MarcChen46 Oct 16, 2023
1414c79
Merge branch 'main' into user/marcchen/DynamicEx_PcdBmcTimeoutSeconds
apop5 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion IpmiFeaturePkg/IpmiFeaturePkg.dec
View file
Open in desktop
apop5 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiCommandTimeoutSeconds|5|UINT8|0xF0000003
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiCommandMaxReties|3|UINT8|0xF0000004
gIpmiFeaturePkgTokenSpaceGuid.PcdBmcTimeoutSeconds|30|UINT8|0xF0000005
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8|0xF0000006
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSelOemManufacturerId|{0, 0, 0}|VOID*|0xF0000007
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0xF000000A
#
Expand Down Expand Up @@ -157,3 +156,6 @@
gIpmiFeaturePkgTokenSpaceGuid.PcdSmbiosTablesIpmiInterruptNumber|0x00|UINT8|0xF0000019
gIpmiFeaturePkgTokenSpaceGuid.PcdSmbiosTablesIpmiI2CSlaveAddress|0x20|UINT8|0xF000001A
gIpmiFeaturePkgTokenSpaceGuid.PcdSmbiosTablesIpmiNVStorageDeviceAddress|0xff|UINT8|0xF000001B

[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx]
gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8|0xD0000001