This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor NNI manager globals (step 1) - argparse #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 26, 2022 02:28
ymkzpx
approved these changes
Jan 26, 2022
the command is |
Ooops, seems there was a bug in my mind. |
QuanluZhang
reviewed
Feb 21, 2022
| def to_command_line_args(self): | ||
| ret = [] | ||
| for field in fields(self): | ||
| value = getattr(self, field.name) | ||
| if value is not None: | ||
| ret.append('--' + field.name) | ||
| ret.append('--' + field.name.replace('_', '-')) |
J-shang
approved these changes
Feb 21, 2022
QuanluZhang
approved these changes
Mar 1, 2022
|
There is a conflict, pls fix it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor NNI manager's argparse with de facto standard library
yargs.Changed args and options:
start_mode->actionbecause "mode" has too many meanings in NNI manager.new->createbecause the command is called "nnictl create".resume + readonly->viewbecause the command is called "nnictl view".log_dir->experiments-directoreybecause it is not log dir at all.experimentWorkingDirectorybut... it was a mistake. I thought it was~/nni-experiments/<ID>but no, it is just~/nni-experiments.Checklist
How to test
Test together with following up PRs.