This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Refactor NNI manager globals (step 1) - argparse #4510
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
|
||
/** | ||
* Parse NNI manager's command line arguments. | ||
**/ | ||
|
||
import assert from 'assert/strict'; | ||
|
||
import yargs from 'yargs/yargs'; | ||
|
||
/** | ||
* Command line arguments provided by "nni/experiment/launcher.py". | ||
* | ||
* Hyphen-separated words are automatically converted to camelCases by yargs lib, but snake_cases are not. | ||
* So it supports "--log-level" but does not support "--log_level". | ||
**/ | ||
export interface NniManagerArgs { | ||
readonly port: number; | ||
readonly experimentId: string; | ||
readonly action: 'create' | 'resume' | 'view'; | ||
readonly experimentsDirectory: string; // must be absolute | ||
readonly logLevel: 'critical' | 'error' | 'warning' | 'info' | 'debug'; | ||
readonly foreground: boolean; | ||
readonly urlPrefix: string; // leading and trailing slashes must be stripped | ||
|
||
// these are planned to be removed | ||
readonly mode: string; | ||
readonly dispatcherPipe: string | undefined; | ||
} | ||
|
||
export function parseArgs(rawArgs: string[]): NniManagerArgs { | ||
const parser = yargs(rawArgs).options(yargsOptions).strict().fail((_msg, err, _yargs) => { throw err; }); | ||
const parsedArgs: NniManagerArgs = parser.parseSync(); | ||
|
||
// strip yargs leftovers | ||
const argsAsAny: any = {}; | ||
for (const key in yargsOptions) { | ||
argsAsAny[key] = (parsedArgs as any)[key]; | ||
assert(!Number.isNaN(argsAsAny[key]), `Command line arg --${key} is not a number`); | ||
} | ||
if (argsAsAny.dispatcherPipe === '') { | ||
argsAsAny.dispatcherPipe = undefined; | ||
} | ||
const args: NniManagerArgs = argsAsAny; | ||
|
||
const prefixErrMsg = `Command line arg --url-prefix "${args.urlPrefix}" is not stripped`; | ||
assert(!args.urlPrefix.startsWith('/') && !args.urlPrefix.endsWith('/'), prefixErrMsg); | ||
|
||
return args; | ||
} | ||
|
||
const yargsOptions = { | ||
port: { | ||
demandOption: true, | ||
type: 'number' | ||
}, | ||
experimentId: { | ||
demandOption: true, | ||
type: 'string' | ||
}, | ||
action: { | ||
choices: [ 'create', 'resume', 'view' ] as const, | ||
demandOption: true | ||
}, | ||
experimentsDirectory: { | ||
demandOption: true, | ||
type: 'string' | ||
}, | ||
logLevel: { | ||
choices: [ 'critical', 'error', 'warning', 'info', 'debug' ] as const, | ||
demandOption: true | ||
}, | ||
foreground: { | ||
default: false, | ||
type: 'boolean' | ||
}, | ||
urlPrefix: { | ||
default: '', | ||
type: 'string' | ||
}, | ||
|
||
mode: { | ||
default: '', | ||
type: 'string' | ||
}, | ||
dispatcherPipe: { | ||
default: '', | ||
type: 'string' | ||
} | ||
} as const; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this update?