This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix version check #906
Merged
Fix version check #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Add different tuner config files for config_test (microsoft#760)
merge master
merge master
Improve the performance of the curve fitting assessor (microsoft#717)
update Chinese file path as en_US (microsoft#764)
Support trialkeeper pipe outputStream flush (microsoft#782)
merge master
merge master
merge master
merge master
fix annotation key-error (microsoft#806)
Fix integration test dependencies (microsoft#822)
merge master
merge master
merge master
Fix installation (microsoft#864)
merge master
merge master
yds05
approved these changes
Mar 22, 2019
chicm-ms
reviewed
Mar 22, 2019
chicm-ms
reviewed
Mar 22, 2019
chicm-ms
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one kind of version string like 'v0.5.2-gews11f', it is generated by installing from source code.
In current trialKeeper, use exact version match, and this version string will cause code break in msranni/nni image, because our offical image use clean number version.
Change the logic to fuzzy match, only match the main number of nni.