This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version check document in PAI, remote, kubeflow and frameworkcontroller #947
Add version check document in PAI, remote, kubeflow and frameworkcontroller #947
Changes from all commits
d77a99c
695d866
b7e9799
7cb03f9
44d1565
7ab7386
d9e1ea8
2c225a8
be23f55
6f760ab
9161209
e661c55
4e5d836
f80e737
aefc219
4fec2cc
dc45661
11fec6f
a03a191
7c7832c
2c862dc
85c015d
85cb472
3784355
d91c980
9786650
ef176d2
1089e80
627e823
b633c26
035d58b
cd549df
964743a
8422992
40391ec
1d84526
1852457
754a354
1ee9735
9f4485c
b1c3774
5d7923e
281f3dc
2ce9157
571a7af
f09d51a
41a9a59
21165b5
d25f7b5
17e719e
e25ffbd
5e777d2
6ff24a5
ccf6c04
eb5e21c
f796c60
e1ae623
ec41d56
080ae00
f0a2d39
2792098
d3adab4
b4cb815
3c5ec02
79a3bb5
0be85b0
ab4b416
20f5aed
905b6eb
fdba019
ed56f82
8a22c66
8f17953
dc432b4
f2946f7
d926e85
398b2c6
8d3c3f1
d70481a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to consider how to show errors in NNI cleanup to end-user, but you can improve later after v0.6 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will refactor the logic in next release.