Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Create Function for Filtering/Scrubbing UserInfo Before Logging #660

Closed
nharper285 opened this issue Mar 10, 2021 · 0 comments
Closed

Create Function for Filtering/Scrubbing UserInfo Before Logging #660

nharper285 opened this issue Mar 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@nharper285
Copy link
Contributor

NOTE: I'm just creating this issue for my PR.
I am implementing a function that will scrub UserInfo before OneFuzz logs anything to Application Insights.

@nharper285 nharper285 added the enhancement New feature or request label Mar 10, 2021
@ghost ghost added the Needs: triage label Mar 10, 2021
ghost pushed a commit that referenced this issue Mar 15, 2021
## Summary of the Pull Request

_What is this about?_
Due to our GDPR privacy requirements, we decided that it would be best to completely purge personal identifiable information from our AppInsights telemetry and logging. Instead of just removing all of the logging statements with personal info, I created a filter function that logs telemetry after it's been run through a recursive scrubbing function. This PR includes this new scrubbing function. 

## PR Checklist
* [x] Applies to work item: #660
* [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/onefuzz) and sign the CLI.
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Info on Pull Request

_What does this include?_
Includes changes to events.py in onefuzzlib. I've implemented functionality - log_event() - to recursively check Event structures for UserInfo before logging to AppInsights. 

## Validation Steps Performed
I run local tests using a script I created with test events. 

_How does someone test & validate?_
I can provide local testing script. If that is insufficient, I can write a unit test that will run against this code.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants