This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Added UserInfo Filter Logging Function #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
…ective of timestamp.
…t irrespective of timestamp." This reverts commit cbf9dd3. Need to create a new PR
bmc-msft
reviewed
Mar 10, 2021
gdhuper
reviewed
Mar 10, 2021
bmc-msft
reviewed
Mar 10, 2021
bmc-msft
reviewed
Mar 10, 2021
This reverts commit cb6bb15.
|
integration tests running |
chkeita
reviewed
Mar 11, 2021
chkeita
reviewed
Mar 11, 2021
|
@bmc-msft, I got an email that this had been merged, but I'm seeing that merged was blocked above. What is the status of this PR? |
…arper285/onefuzz into user/noharper/scrub-user-info
chkeita
approved these changes
Mar 15, 2021
|
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Due to our GDPR privacy requirements, we decided that it would be best to completely purge personal identifiable information from our AppInsights telemetry and logging. Instead of just removing all of the logging statements with personal info, I created a filter function that logs telemetry after it's been run through a recursive scrubbing function. This PR includes this new scrubbing function.
PR Checklist
Info on Pull Request
What does this include?
Includes changes to events.py in onefuzzlib. I've implemented functionality - log_event() - to recursively check Event structures for UserInfo before logging to AppInsights.
Validation Steps Performed
I run local tests using a script I created with test events.
How does someone test & validate?
I can provide local testing script. If that is insufficient, I can write a unit test that will run against this code.