This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
adding function app settings bicep template and updating deploy.py #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or toggling function states through enable_dotnet argument
chkeita
reviewed
May 24, 2022
src/deployment/bicep-templates/function-settings-disabled-apps.bicep
Outdated
Show resolved
Hide resolved
stishkin
reviewed
May 24, 2022
chkeita
reviewed
May 24, 2022
chkeita
approved these changes
May 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds app settings for all dotnet and python functions to automatically disable (AzureWebJobs.$FUNCTION.Disabled=1) all dotnet functions and enable all python functions in their corresponding function apps
To enable dotnet functions at deployment time, deploy.py was updated with an argument '--enable_dotnet' that accepts a space separated list of
dotnetpython functions to disable while enabling the dotnet function of the same name (except pascal cased names for dotnet vs python snake cased names)example:
This would enable the Tasks, Webhooks, and Pool functions in dotnet and turn these off in python
PR Checklist
Info on Pull Request
added:
src/deployment/bicep-templates/function-settings-disabled-apps.bicep
updated:
src/deployment/azuredeploy.bicep
src/deployment/bicep-templates/function-settings.bicep
src/deployment/deploy.py