Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Devcontainer: Move global tool installs into another script so they can be cached #2365

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Sep 8, 2022

The postCreateCommand is not cached, so move global tool installations out of that script and into a new one that is invoked from the Dockerfile.

Note: this removes the python devcontainer feature and we install it ourselves, or else we cannot use pip in the script invoked from the Dockerfile. There seems to be no way to run a command that will be cached after the devcontainer features are installed.

@Porges Porges enabled auto-merge (squash) September 8, 2022 22:25
@Porges Porges merged commit e1420e1 into main Sep 8, 2022
@Porges Porges deleted the move-installs-out-of-post-create-script branch September 12, 2022 21:11
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants