Devcontainer: Move global tool installs into another script so they can be cached

.devcontainer/Dockerfile

@@ -11,10 +11,16 @@ ARG RUSTVERSION="1.63"
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     && apt-get -y install --no-install-recommends \
     libunwind-dev clang build-essential libssl-dev pkg-config lldb \
-    bash-completion npm python-is-python3 \
-    dotnet6
+    bash-completion npm dotnet6 \
+    python-is-python3 direnv uuid-runtime python3-distutils python3-pip
 
 # Install Rust:
 USER vscode
 RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain ${RUSTVERSION} -y
+
+# Install other dependencies:
+COPY install-dependencies.sh .
+RUN ./install-dependencies.sh 
+
 USER root
+RUN rm install-dependencies.sh

.devcontainer/devcontainer.json

@@ -41,7 +41,6 @@
 	"remoteUser": "vscode",
 	// Note: available features are listed in: https://github.com/microsoft/vscode-dev-containers/blob/main/script-library/container-features/src/devcontainer-features.json
 	"features": {
-		"azure-cli": "latest",
-		"python": "os-provided"
+		"azure-cli": "latest"
 	}
 }

.devcontainer/install-dependencies.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+set -eux
+
+# Note that this script runs as user 'vscode' during devcontainer setup.
+
+# Rust global tools, needed to run CI scripts
+"$HOME/.cargo/bin/cargo" install cargo-audit cargo-license@0.4.2
+
+# NPM global tools
+sudo npm install -g azurite azure-functions-core-tools@4
+
+# Pip global tools
+pip install wheel
+
+# Other binaries
+echo "Installing azcopy ..."
+tmpdir=$(mktemp -d)
+pushd "$tmpdir"
+wget https://aka.ms/downloadazcopy-v10-linux -O - | tar -zxv
+sudo cp ./azcopy_linux_amd64_*/azcopy /usr/bin/
+popd
+rm -rf "$tmpdir"

.devcontainer/post-create-script.sh

@@ -1,24 +1,9 @@
 #!/bin/bash
 
-# Install Azure Functions Core Tools 4
-# Source: https://docs.microsoft.com/en-us/azure/azure-functions/functions-run-local?tabs=v4%2Clinux%2Ccsharp%2Cportal%2Cbash
-echo "Installing Azure Functions Core Tools 4 ..."
-# note that 'dotnet' feature in devcontainer.json already sets up the PPA for this
-sudo apt install azure-functions-core-tools-4
-
-# Install azcopy
-echo "Installing azcopy ..."
-cd /tmp
-wget https://aka.ms/downloadazcopy-v10-linux
-tar -xvf downloadazcopy-v10-linux
-sudo cp ./azcopy_linux_amd64_*/azcopy /usr/bin/
-
-# Install Azurite
-sudo npm install -g azurite
+set -eux
 
 # Restore rust dependencies
 echo "Restoring rust dependencies"
-cargo install cargo-audit cargo-license@0.4.2 # requirements if you want to run ci/agent.sh
 cd /workspaces/onefuzz/src/agent
 cargo fetch
 
@@ -27,9 +12,6 @@ echo "Restore dotnet dependencies"
 cd /workspaces/onefuzz/src/ApiService
 dotnet restore
 
-sudo apt-get install direnv uuid-runtime
-pip install wheel
-
 echo "Setting up venv"
 cd /workspaces/onefuzz/src
 python -m venv venv