This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Cache VMSS VM InstanceID lookups #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
- Coverage 30.02% 29.99% -0.03%
==========================================
Files 288 288
Lines 35338 35366 +28
==========================================
Hits 10609 10609
- Misses 24729 24757 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
stishkin
reviewed
Sep 29, 2022
stishkin
approved these changes
Sep 29, 2022
tevoinea
approved these changes
Sep 29, 2022
nharper285
approved these changes
Sep 29, 2022
mgreisen
approved these changes
Sep 29, 2022
Porges
force-pushed
the
cache-instanceid-lookup
branch
from
fee934e to
7c64453
Compare
Porges
force-pushed
the
cache-instanceid-lookup
branch
from
7c64453 to
1c4c970
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potentially expensive operation as we need to fetch every VM in the Scaleset to find the VMID we are looking for.
This should be safe to cache "forever" since the mapping will not change.
It seems like we should be storing the
InstanceIDinstead of (as well as?) the VMID, but that is hard to change at the moment. Perhaps after C# port is completed.