This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Updated keyvault access policy #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Codecov Report
@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
+ Coverage 28.70% 29.67% +0.97%
==========================================
Files 174 332 +158
Lines 21483 39259 +17776
==========================================
+ Hits 6166 11651 +5485
- Misses 15317 27608 +12291 |
mgreisen
reviewed
Jun 27, 2023
mgreisen
approved these changes
Jun 27, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR corrects the Object ID for the Microsoft.Azure.WebSites service account in the KeyVault access policy and also toggles
enabledForDeployment: truethat's needed for cert installation on the Function App host.Fixes #3108
PR Checklist
Info on Pull Request
updated:
src/deployment/azuredeploy.bicep