This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add generic coverage task #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ranweiler
commented
May 26, 2021
ranweiler
commented
May 26, 2021
| @@ -72,6 +74,12 @@ def _create_tasks( | |||
| ), | |||
| ] | |||
|
|
|||
| # We don't really need a separate timeout for crash reporting, and we could just | |||
There was a problem hiding this comment.
Compare with definition of coverage_timeout below.
Open to suggestions here; we could also just NOT introduce a new template arg, reuse crash_report_timeout, and unify them later as a breaking change.
|
This failure seems unrelated to my changes: https://github.com/microsoft/onefuzz/pull/763/checks?check_run_id=2679243380 |
|
yeah, I'm seeing the same failure on another PR. #830 just failed with the same issue. |
this fixes an issue related to object id reuse that can occur making the object identification cache fail. Instead, this simplifies the hide_secrets to always recurse and use setattr to always set the value based on the recursion. Note, the object id reuse issue was seen in the `events.filter_event_recurse` development and this was the fix for the id reuse there. Python documentation states: id(object): Return the “identity” of an object. This is an integer (or long integer) which is guaranteed to be unique and constant for this object during its lifetime. Two objects with non-overlapping lifetimes may have the same id() value.
…sing-content' into generic-cov-task
bmc-msft
suggested changes
May 27, 2021
There was a problem hiding this comment.
Running the integration tests gives this error similar to this for all of the Linux jobs:
ERROR:integration:task failed: linux-libfuzzer - coverage (code=<ErrorCode.TASK_FAILED: 468> errors=['task failed. exit_status:code=1 signal=None success=False', '', '[2021-05-27T17:48:48Z INFO onefuzz_agent::tasks::config] agent ready, dispatching task\n[2021-05-27T17:48:48Z INFO onefuzz_agent::tasks::config] task_start event_type:coverage\n[2021-05-27T17:48:48Z INFO onefuzz_agent::tasks::coverage::generic] starting coverage task\n[2021-05-27T17:48:50Z ERROR onefuzz_agent::managed::cmd] error running task: No such file or directory (os error 2)\nError: No such file or directory (os error 2)\n'])
and an error similar to this for all of the windows jobs:
ERROR:integration:task failed: windows-libfuzzer-linked-library - coverage (code=<ErrorCode.TASK_FAILED: 468> errors=['task failed. exit_status:code=1 signal=None success=False', '', '[2021-05-27T17:53:01Z INFO onefuzz_agent::tasks::config] agent ready, dispatching task\n[2021-05-27T17:53:01Z INFO onefuzz_agent::tasks::config] task_start event_type:coverage\n[2021-05-27T17:53:01Z INFO onefuzz_agent::tasks::coverage::generic] starting coverage task\n[2021-05-27T17:53:04Z ERROR onefuzz_agent::managed::cmd] error running task: The system cannot find the file specified. (os error 2)\nError: The system cannot find the file specified. (os error 2)\n'])
bmc-msft
approved these changes
Jun 3, 2021
|
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: