Add timeout when recording Linux coverage #929

ranweiler · 2021-05-26T05:45:46Z

Simplify the Linux block coverage Recorder API
Add a (mandatory) timeout to recording runs

Closes #923.

src/agent/coverage/src/block/linux.rs

ghost · 2021-05-26T18:04:35Z

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 5 hours 41 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

**Todo:** - [x] Finalize format for coverage file(s) - [x] Add service support - [x] Integration test - [x] Merge #926 - [x] Merge #929

ranweiler added 3 commits May 26, 2021 05:44

Add timeout when recording Linux coverage

405fd16

Move tracee handling to private fn

d24ce03

Rely on drop for cancellation

cf7ede6

ranweiler commented May 26, 2021

View reviewed changes

src/agent/coverage/src/block/linux.rs Outdated Show resolved Hide resolved

bmc-msft approved these changes May 26, 2021

View reviewed changes

Increase maximum poll period

efdbc80

bmc-msft added the auto-merge label May 26, 2021

Merge branch 'main' into coverage-timeout

766119c

ranweiler mentioned this pull request May 26, 2021

Add generic coverage task #763

Merged

5 tasks

bmc-msft and others added 2 commits May 26, 2021 14:30

Merge branch 'main' into coverage-timeout

1226e83

Merge branch 'main' into coverage-timeout

7033db3

ranweiler merged commit 87eb8ac into microsoft:main May 26, 2021

ranweiler deleted the coverage-timeout branch May 26, 2021 19:22

ghost pushed a commit that referenced this pull request Jun 3, 2021

Add generic coverage task (#763)

2c72bd5

**Todo:** - [x] Finalize format for coverage file(s) - [x] Add service support - [x] Integration test - [x] Merge #926 - [x] Merge #929

ghost locked as resolved and limited conversation to collaborators Jun 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timeout when recording Linux coverage #929

Add timeout when recording Linux coverage #929

ranweiler commented May 26, 2021

ghost commented May 26, 2021

Add timeout when recording Linux coverage #929

Add timeout when recording Linux coverage #929

Conversation

ranweiler commented May 26, 2021

ghost commented May 26, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.