-
Notifications
You must be signed in to change notification settings - Fork 83
Fixes for when attr type can be ambiguous for empty lists #2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with attribute type ambiguity when working with empty lists in constant folding operations. The changes ensure that integer list attributes are properly typed using ir.AttrInt64s
instead of passing raw Python lists.
- Updates
gather
operation to use properly typedir.AttrInt64s
forvalue_ints
parameter - Updates
shape
operation to use properly typedir.AttrInt64s
forvalue_ints
parameter
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Fixes according to onnx/ir-py#162