Default attribute type to INTS to avoid breaking BC #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 76.35% 76.33% -0.02%
==========================================
Files 40 40
Lines 4808 4809 +1
Branches 952 952
==========================================
Hits 3671 3671
- Misses 839 840 +1
Partials 298 298 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Aug 21, 2025
justinchuby
added a commit
to microsoft/onnxscript
that referenced
this pull request
Aug 22, 2025
Fixes according to onnx/ir-py#162 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default attribute type to INTS in convenience functions because otherwise the behavior would be BC breaking.