[Rewriter] Prevent out of range when matching node outputs #2508
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to bind more outputs (from the pattern) than there are actual outputs of the candidate node now simply rejects the node before even trying to index into the list of node outputs. Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
justinchuby
requested review from
gramalingam and
Copilot
and removed request for
gramalingam
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential out-of-bounds error in the rewriter module when matching pattern node outputs against actual node outputs. The change prevents indexing into node.outputs when the pattern expects more outputs than the candidate node actually has.
Key Changes
- Added bounds checking in
_match_nodemethod to verify the pattern output index is within the range of actual node outputs
justinchuby
reviewed
Aug 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
- Coverage 70.08% 70.05% -0.03%
==========================================
Files 215 215
Lines 25810 25833 +23
Branches 2587 2597 +10
==========================================
+ Hits 18089 18098 +9
- Misses 6823 6837 +14
Partials 898 898 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Christoph Berganski <christoph.berganski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to bind more outputs (from the pattern) than there are actual outputs of the candidate node now simply rejects the node before even trying to index into the list of node outputs.