Skip to content

[Rewriter] Prevent out of range when matching node outputs #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

[Rewriter] Prevent out of range when matching node outputs #2508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46a2c9
[Rewriter] Prevent out of range when matching node outputs
iksnagreb Aug 22, 2025
a79f117
[Rewriter] Clarify rejecting nodes due to index out of range
iksnagreb Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions onnxscript/rewriter/_matcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,12 @@ def _match_node(self, pattern_node: _pattern_ir.NodePattern, node: ir.Node) -> b
return False

for i, output_value_pattern in enumerate(pattern_node.outputs):
# When trying to bind more outputs (from the pattern) than there are
# actual outputs of the candidate node, reject the node before even
# trying to index into the list of node outputs.
if i >= len(node.outputs):
return False

if not self._match.bind_value(output_value_pattern, node.outputs[i]):
return False

Expand Down
Loading