add job history rest-server & webportal, query by frameworkcontroller… #3623
Conversation
There was a problem hiding this comment.
@abuccts @sunqinzheng It is a low priority PR and will not be included in the first release, so could u please take a look this when you free?
| @@ -35,4 +35,11 @@ app.listen(config.serverPort, () => { | |||
| logger.info('RESTful API server starts on port %d', config.serverPort); | |||
| }); | |||
|
|
|||
| module.exports = app; | |||
| esApp.listen(config.esPort, () => { | |||
There was a problem hiding this comment.
I think the elastic search apis should be a sub router of the current rest server so that the third party extensions and rest api users could access these apis easily.
There was a problem hiding this comment.
Another solution is just like the prometheus server. We just expose the elastic search's endpoint and let user customizes their queries.
| @@ -94,8 +94,10 @@ export default class Summary extends React.Component { | |||
| modalTitle: '', | |||
| autoReloadInterval: 10 * 1000, | |||
| hideDialog: true, | |||
| currentAttemptID: this.props.jobInfo.jobStatus.retries, | |||
There was a problem hiding this comment.
I will implement an independent job attempts page. Please seperate the frontend works and check in the api changes only.
| }, | ||
| }, | ||
| 'sort': { | ||
| 'CollectTime': 'desc', |
There was a problem hiding this comment.
CollectTime [](start = 7, length = 11)
Rename all places:
CollectTime -> collectTime
ObjectSnapshot -> objectSnapshot
| let resultObj = {'items': []}; | ||
| for (let i = 0; i < aggResults.length; i++) { | ||
| resultObj['items'].push(aggResults[i].CollectTime_sort.buckets[0].top.hits.hits[0]._source.ObjectSnapshot); | ||
| } |
There was a problem hiding this comment.
May can be replaced by:
"CollectTime_sort": {
"terms": {
"field": "collectTime",
"size": 1,
"order": {
"_key": "desc"
}
},
"aggs": {
"top": {
"top_hits": {
"size": 1
}
}
}
}
There was a problem hiding this comment.
Or:
"CollectTime_sort": {
"top_hits": {
"sort": [
{
"collectTime": {
"order": "desc"
}
}
],
"size": 1
}
}
In reply to: 339911150 [](ancestors = 339911150)
|
Close it as it is refined to be #3831 |
add job history rest-server & webportal, query by frameworkcontroller…