This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add api endpoint and webportal page of job retry history #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debuggy
requested review from
sunqinzheng,
abuccts,
Binyang2014,
mydmdm,
yqwang-ms,
hzy46,
fanyangCS and
qfyin
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
abuccts
reviewed
Nov 12, 2019
yqwang-ms
reviewed
Nov 12, 2019
yqwang-ms
reviewed
Nov 12, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
latest UI: |
|
Complement exit diagnostics message:
|
sunqinzheng
reviewed
Nov 19, 2019
| Exit Type: | ||
| </div> | ||
| <div className={c(FontClassNames.mediumPlus)}> | ||
| {`${jobRetry.exitType}`} |
There was a problem hiding this comment.
The template string is unnecessary.
sunqinzheng
reviewed
Nov 19, 2019
| box-shadow: rgba(0, 0, 0, 0.06) 0px 2px 4px, rgba(0, 0, 0, 0.05) 0px 0.5px 1px; | ||
| `; | ||
|
|
||
| const TaskRoleCard = styled.div` |
There was a problem hiding this comment.
The Card component has style and classname props, you can add your custom style there.
I think you don't need to create a new component with copied code here.
sunqinzheng
reviewed
Nov 19, 2019
| @@ -70,9 +71,9 @@ const AbnormalJobList = ({ jobs, style }) => { | |||
| onRender(job) { | |||
| const { legacy, name, namespace, username } = job; | |||
| const href = legacy | |||
| ? `/job-detail.html?jobName=${name}` | |||
| ? `/job-detail.html?jobname=${name}` | |||
There was a problem hiding this comment.
The camelCase jobName and lowercase username is defined in rest api. I think we need to keep the consistency here
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add job attempt api
Attempts include job retry history from elastic search and current job info from k8s api. The attempt schema is converted from framework.
add page job-retry.html to webportal
closes #3788