Gracefully handle invalid characters in PATH.#2296
Merged
cincuranet merged 1 commit intomicrosoft:mainfrom Sep 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds graceful handling for invalid characters or paths in the PATH environment variable by wrapping Path.Combine in a try-catch block to prevent exceptions when processing potentially malformed PATH entries.
- Replaced direct Path.Combine call with a new TryCombinePaths helper method that handles exceptions
- Added a local static helper function to safely combine paths and return success/failure status
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
brianrob
approved these changes
Sep 8, 2025
This was referenced Oct 13, 2025
Closed
This was referenced Oct 22, 2025
Merged
This was referenced Oct 31, 2025
Closed
This was referenced Nov 12, 2025
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2293.