Skip to content

Gracefully handle invalid characters in PATH. #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cincuranet merged 1 commit into from
Sep 8, 2025
Merged

Gracefully handle invalid characters in PATH. #2296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/PerfView/SymbolReaderHttpHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,14 +436,28 @@ private static string GetFileOnEnvironmentPath(string fileName)
{
foreach (string folder in Environment.GetEnvironmentVariable("PATH").Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
{
string path = Path.Combine(folder, fileName);
if (File.Exists(path))
if (TryCombinePaths(folder, fileName, out var path) && File.Exists(path))
{
return path;
}
}

return null;

// PATH environment variable may contain invalid paths/characters.
static bool TryCombinePaths(string path1, string path2, out string result)
{
try
{
result = Path.Combine(path1, path2);
return true;
}
catch (ArgumentException)
{
result = default;
return false;
}
}
}

/// <summary>
Expand Down