[REGRESSION]: page.evaluate with a string no longer works unless wrapped in an IIFE

[trusktr]

Context:

• GOOD Playwright Version: [what Playwright version worked nicely?] 1.8
• BAD Playwright Version: [what Playwright version doesn't work any more?] 1.17
• Operating System: [e.g. Windows, Linux or Mac] Ubuntu
• Extra: [any specific details about your environment]

Code Snippet

    function add(...addends) {
      return addends.reduce(
        (accumulator, currentValue) => accumulator + currentValue
      );
    }

    const functionResult = await page.evaluate(`
      ${add.toString()}
      var result = add(1, 2, 3);
      Promise.resolve(result);
    `);

Describe the bug

I get the error:

    page.evaluate: SyntaxError: Unexpected token 'var'

I am trying to migrate from an older jest-playwright-preset setup to @playwright/test, in the process updating playwright. This code worked before.

[trusktr]

What other info can I provide?

[dgozman]

@trusktr I can repro this. I guess something has changed, but I am not sure we are going to fix this. I'd suggest to wrap your code in the IIFE, to have a scope to declare variables. Sorry for the inconvenience.

const functionResult = await page.evaluate(`(() => {
    ${add.toString()}
    var result = add(1, 2, 3);
    return Promise.resolve(result);
})()`);