Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REGRESSION]: page.goto worked fine on 1.8, times out on 1.17 #11570

Closed
trusktr opened this issue Jan 22, 2022 · 4 comments
Closed

[REGRESSION]: page.goto worked fine on 1.8, times out on 1.17 #11570

trusktr opened this issue Jan 22, 2022 · 4 comments

Comments

@trusktr
Copy link

trusktr commented Jan 22, 2022 •
edited
Loading

Context:

  • GOOD Playwright Version: [what Playwright version worked nicely?] 1.8
  • BAD Playwright Version: [what Playwright version doesn't work any more?] 1.17
  • Operating System: [e.g. Windows, Linux or Mac] Linux
  • Extra: [any specific details about your environment] playwright docker image

Code Snippet

My code does

    await page.goto('http://127.0.0.1:3001/docs/index.html#/');

and it was working until I updated. I'm not sure what the root cause is, maybe it isn't page.goto's issue, but that's how I encounter it.

Describe the bug

On 1.8, this work fine. on 1.17, it times out.
@trusktr trusktr mentioned this issue Jan 22, 2022
Closed
trusktr added a commit to docsifyjs/docsify that referenced this issue Jan 23, 2022
@trusktr
pin playwright to 1.8 to avoid regressions, and fix flaky tests
38f2d24 
Playwright had some in-range breaking changes (regressions): microsoft/playwright#10819 and microsoft/playwright#11570

Playwright tests need to `await onceRendered()` after each route navigation to wait for render to finish before testing the state of the rendered DOM. Tests were flaky because they were looking for DOM before render finished (sometimes).

Additionally, this fixes one test that was failing only locally, but not in CI, due to a RegExp check against page.url() (not sure why it would differ on CI vs local, but now the URL is explicit).
@mxschmitt
Copy link
Member

Would it be possible that you provide us a repro for this (localhost web-server)? Otherwise we can't act on that.

@aslushnikov
Copy link
Contributor

Please re-file with a good repro!

@trusktr
Copy link
Author

trusktr commented Jan 29, 2022 •
edited
Loading

We're moving too fast. Someone updated playwright in our project and even moved from jest-playwright to playwright's official test runner. Good to close, and we'll move along with that latest setup.

@mxschmitt
Copy link
Member

We're moving too fast. Someone updated playwright in our project and even moved from jest-playwright to playwright's official test runner. Good to close, and we'll move along with that latest setup.

AMAZING! 🎉

@tillschander tillschander mentioned this issue Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trusktr @aslushnikov @mxschmitt