New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate toMatchSnapshot #26612

Closed

pavelfeldman opened this issue Aug 22, 2023 · 0 comments · Fixed by #26718

Assignees

Labels

v1.38

Member

pavelfeldman commented Aug 22, 2023

No description provided.

pavelfeldman added the v1.38 label

pavelfeldman assigned dgozman

dgozman mentioned this issue

feat: deprecate toMatchSnapshot for buffers #26718

Merged

dgozman closed this as completed in #26718

dgozman added a commit that referenced this issue


          feat: deprecate toMatchSnapshot for buffers (#26718)

8348f66

These are usually used for screenshots instead of toHaveScreenshot.
String-based snapshots are left as is.

<img width="836" alt="deprecated"
src="https://github.com/microsoft/playwright/assets/9881434/d02818da-7eea-47fc-8ea8-4104b0dd49b5">

---

Also deemphasized toMatchSnapshot throughout all docs.

Fixes #26612.

Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue


          feat: deprecate toMatchSnapshot for buffers (microsoft#26718)

5dc4c8a

These are usually used for screenshots instead of toHaveScreenshot.
String-based snapshots are left as is.

<img width="836" alt="deprecated"
src="https://github.com/microsoft/playwright/assets/9881434/d02818da-7eea-47fc-8ea8-4104b0dd49b5">

---

Also deemphasized toMatchSnapshot throughout all docs.

Fixes microsoft#26612.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment