-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate toMatchSnapshot for buffers #26718
Conversation
This comment has been minimized.
This comment has been minimized.
These are usually used for screenshots instead of toHaveScreenshot. String-based snapshots are left as is. Also updated docs to deemphasize toMatchSnapshot.
c3df2d1
to
1a81386
Compare
Test results for "tests 1"2 failed 7 flaky 22458 passed, 478 skipped ❌ [default] › run-tests.spec.ts:953:5 › should produce output twice
❌ [reuse] › run-tests.spec.ts:953:5 › should produce output twice
Merge workflow run. |
This reverts commit 8348f66.
- This reverts commit microsoft@8348f66 landed in microsoft#26718. - Update docs to point towards `toHaveScreenshot`.
These are usually used for screenshots instead of toHaveScreenshot. String-based snapshots are left as is. <img width="836" alt="deprecated" src="https://github.com/microsoft/playwright/assets/9881434/d02818da-7eea-47fc-8ea8-4104b0dd49b5"> --- Also deemphasized toMatchSnapshot throughout all docs. Fixes microsoft#26612.
- This reverts commit microsoft@8348f66 landed in microsoft#26718. - Update docs to point towards `toHaveScreenshot`.
These are usually used for screenshots instead of toHaveScreenshot. String-based snapshots are left as is.
Also deemphasized toMatchSnapshot throughout all docs.
Fixes #26612.