Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert toMatchSnapshot deprecation #27089

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: revert toMatchSnapshot deprecation #27089

merged 2 commits into from
Sep 14, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 14, 2023

@github-actions
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [webkit] › library/browsercontext-fetch.spec.ts:1039:3 › should abort requests when browser context closes

25600 passed, 600 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 603861c into microsoft:main Sep 14, 2023
27 of 28 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Sep 14, 2023
@dgozman
cherry-pick(microsoft#27089): fix: revert toMatchSnapshot deprecation
aa22c17 
- This reverts commit
microsoft@8348f66
landed in microsoft#26718.
- Update docs to point towards `toHaveScreenshot`.
dgozman added a commit that referenced this pull request Sep 14, 2023
@dgozman
cherry-pick(#27089): fix: revert toMatchSnapshot deprecation (#27091)
9271ba9 
- This reverts commit
8348f66
landed in #26718.
- Update docs to point towards `toHaveScreenshot`.

Fixes #27071.
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@dgozman @Germandrummer92
fix: revert toMatchSnapshot deprecation (microsoft#27089)
5738920 
- This reverts commit
microsoft@8348f66
landed in microsoft#26718.
- Update docs to point towards `toHaveScreenshot`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @aslushnikov