Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] make every package depend on playwright #26614

Closed
5 tasks done
dgozman opened this issue Aug 22, 2023 · 2 comments
Closed
5 tasks done

[internal] make every package depend on playwright #26614

dgozman opened this issue Aug 22, 2023 · 2 comments
Assignees
Labels

Comments

@dgozman
Copy link
Contributor

dgozman commented Aug 22, 2023

  • (v1.38) Introduce @playwright/browser-chromium, @playwright/browser-webkit, @playwright/browser-firefox.
  • (v1.38) Make playwright not install browsers.
  • (v1.38) Create migration writeup for playwright package.
  • (v1.38) Move code from playwright-test to playwright, make @playwright/test reexport everything from playwright - chore: make @playwright/test depend on playwright #26946
  • (v1.38) Make playwright-ct-core depend on playwright instead of @playwright/test
@dgozman dgozman added the v1.38 label Aug 22, 2023
@dgozman dgozman self-assigned this Aug 22, 2023
dgozman added a commit that referenced this issue Aug 27, 2023
…26672)

Additionally introduce `@playwright/browser-<browser>` packages that
just download the respective browser, but do not export anything.

References #26614.
@aslushnikov
Copy link
Collaborator

For the record: add a plan of action for this.

@dgozman
Copy link
Contributor Author

dgozman commented Aug 30, 2023

Breaking: Playwright no longer downloads browsers automatically

Note

If you are using @playwright/test package, this change does not affect you.

Playwright recommends to use @playwright/test package and download browsers via npx playwright install command. If you are following this recommendation, nothing has changed for you.

However, up to v1.38, installing the playwright package instead of @playwright/test did automatically download browsers. This is no longer the case, and we recommend to explicitly download browsers via npx playwright install command.

v1.37 and earlier

playwright package was downloading browsers during npm install, while @playwright/test was not.

v1.38 and later

playwright and @playwright/test packages do not download browsers during npm install.

Recommended migration

Run npx playwright install to download browsers after npm install. For example, in your CI configuration:

- run: npm ci
- run: npx playwright install --with-deps

Alternative migration option - not recommended

Add @playwright/browser-chromium, @playwright/browser-firefox and @playwright/browser-webkit as a dependency. These packages download respective browsers during npm install. Make sure you keep the version of all playwright packages in sync:

// package.json
{
  "devDependencies": {
    "playwright": "1.38.0",
    "@playwright/browser-chromium": "1.38.0",
    "@playwright/browser-firefox": "1.38.0",
    "@playwright/browser-webkit": "1.38.0"
  }
}

@dgozman dgozman closed this as completed Sep 18, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
…icrosoft#26672)

Additionally introduce `@playwright/browser-<browser>` packages that
just download the respective browser, but do not export anything.

References microsoft#26614.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants