Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make @playwright/test depend on playwright #26946

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Sep 8, 2023

No description provided.

@dgozman dgozman added the CQ1 label Sep 8, 2023
@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the playwright-test-into-playwright branch from 25a04a2 to b072be5 Compare September 8, 2023 17:27
@dgozman dgozman added CQ1 and removed CQ1 labels Sep 8, 2023
@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the playwright-test-into-playwright branch from b072be5 to a3d3293 Compare September 8, 2023 19:47
@dgozman dgozman added CQ1 and removed CQ1 labels Sep 8, 2023
@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the playwright-test-into-playwright branch from a3d3293 to 117f7ff Compare September 8, 2023 20:45
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.artifacts.spec.ts:257:5 › should work with trace: retain-on-failure

8 flaky
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185:5 › should show screenshot
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25340 passed, 590 skipped
✔️✔️✔️

[playwright-test] › playwright.artifacts.spec.ts:257:5 › should work with trace: retain-on-failure

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -1,6 +1,7 @@
  Array [
+   ".playwright-artifacts-4",
    "artifacts-failing",
    "  trace.zip",
    "artifacts-own-context-failing",
    "  trace.zip",
    "artifacts-persistent-failing",

  266 |   expect(result.passed).toBe(5);
  267 |   expect(result.failed).toBe(5);
> 268 |   expect(listFiles(testInfo.outputPath('test-results'))).toEqual([
      |                                                          ^
  269 |     'artifacts-failing',
  270 |     '  trace.zip',
  271 |     'artifacts-own-context-failing',

    at D:\a\playwright\playwright\tests\playwright-test\playwright.artifacts.spec.ts:268:58

Merge workflow run.

@dgozman dgozman merged commit 186f869 into microsoft:main Sep 8, 2023
27 of 28 checks passed
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Parsium added a commit to Sage/carbon that referenced this pull request Nov 14, 2023
Update to version 1.39

* Only allow patch versions since playwright introduces
  breaking changes in semvar minor versions

Install @playwright/test

* As of version 1.38, @playwright/experimental-ct-react-17
  no longer has @playwright/test as a dependency.
  See PR for details:
  <microsoft/playwright#26946>
Parsium added a commit to Sage/carbon that referenced this pull request Nov 14, 2023
Update to version 1.39

* Only allow patch versions since playwright introduces
  breaking changes in semvar minor versions

Install @playwright/test

* As of version 1.38, @playwright/experimental-ct-react-17
  no longer has @playwright/test as a dependency.
  See PR for details:
  <microsoft/playwright#26946>
Parsium added a commit to Sage/carbon that referenced this pull request Nov 14, 2023
Update to version 1.39

* Only allow patch versions since playwright introduces
  breaking changes in semvar minor versions

Install @playwright/test

* As of version 1.38, @playwright/experimental-ct-react-17
  no longer has @playwright/test as a dependency.
  See PR for details:
  <microsoft/playwright#26946>
Parsium added a commit to Sage/carbon that referenced this pull request Nov 14, 2023
Update to version 1.39

Install @playwright/test

* As of version 1.38, @playwright/experimental-ct-react-17
  no longer has @playwright/test as a dependency.
  See PR for details:
  <microsoft/playwright#26946>
Parsium added a commit to Sage/carbon that referenced this pull request Nov 16, 2023
Update to version 1.39

Install @playwright/test

* As of version 1.38, @playwright/experimental-ct-react-17
  no longer has @playwright/test as a dependency.
  See PR for details:
  <microsoft/playwright#26946>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants