Skip to content

feat(chromium-tip-of-tree): roll to r1159 #27605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Oct 13, 2023

Caused by this upstream 4922641: Enable HttpsUpgrades flag by default | https://chromium-review.googlesource.com/c/chromium/src/+/4922641 change.

When this is enabled, https sites will make a CONNECT request to our proxy which makes the tests fail. Solution would be to e.g. ignore CONNECT requests to indicate that our proxy does not support HTTPS requests (what we did here), alternatively we could disable the flag which would make us not behave like a real Chromium anymore.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Oct 16, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Oct 16, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the roll-into-pw-chromium-tip-of-tree/1159 branch from 2a19e21 to 5cf7bd2 Compare October 17, 2023 19:47
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Oct 17, 2023
@github-actions
Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › components/splitView.spec.tsx:65:5 › drag resize
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:223:5 › should queue watches

25876 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 5262e5a into main Oct 17, 2023
@mxschmitt mxschmitt deleted the roll-into-pw-chromium-tip-of-tree/1159 branch October 17, 2023 20:41
@github-actions
Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
1 failed
❌ [webkit] › library/browsertype-connect.spec.ts:476:5 › run-server › should be able to connect 20 times to a single server without warnings

96 flaky ⚠️ [chromium] › library/tracing.spec.ts:408:14 › should produce screencast frames fit
⚠️ [chromium] › library/chromium/oopif.spec.ts:259:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › page\page-set-input-files.spec.ts:40:3 › should upload large file
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page\page-leaks.spec.ts:123:5 › expect should not leak
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/trace-viewer.spec.ts:1050:1 › should highlight locator in iframe while typing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\inspector\cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page\page-goto.spec.ts:771:3 › should return when navigation is committed if commit is specified
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:408:14 › should produce screencast frames crop
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library/tracing.spec.ts:761:5 › should not emit after w/o before
⚠️ [firefox] › library/hit-target.spec.ts:259:3 › should not click an element overlaying iframe with the target
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library\browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox] › library\browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox] › library\capabilities.spec.ts:191:3 › serviceWorker should intercept document request
⚠️ [firefox] › library\download.spec.ts:122:5 › download event › should report downloads with acceptDownloads: true
⚠️ [firefox] › library\download.spec.ts:568:5 › download event › should emit download event from nested iframes
⚠️ [firefox] › library\hit-target.spec.ts:259:3 › should not click an element overlaying iframe with the target
⚠️ [firefox] › library\signals.spec.ts:25:5 › should close the browser when the node process closes
⚠️ [firefox] › library\video.spec.ts:278:5 › screencast › should expose video path blank page
⚠️ [firefox] › page\page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/capabilities.spec.ts💯3 › should play audio @smoke
⚠️ [firefox] › library/headful.spec.ts:83:3 › should dispatch click events to oversized viewports
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\chromium\oopif.spec.ts:314:3 › should emit filechooser event for iframe
⚠️ [chromium] › page\page-set-input-files.spec.ts:40:3 › should upload large file
⚠️ [chromium] › library/chromium/oopif.spec.ts:329:3 › should not throw on exposeFunction when oopif detaches
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\inspector\cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › page/page-network-idle.spec.ts:83:3 › should wait for networkidle to succeed navigation
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:57:7 › cli codegen › should click locator.nth
⚠️ [webkit] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:323:7 › cli codegen › should fill [contentEditable]
⚠️ [webkit] › library/trace-viewer.spec.ts:1050:1 › should highlight locator in iframe while typing
⚠️ [webkit] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:360:7 › cli codegen › should generate getByTestId
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:392:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:421:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › library\inspector\cli-codegen-pytest.spec.ts:32:5 › should print the correct context options when using a device and lang
⚠️ [webkit] › page\page-add-script-tag.spec.ts:21:3 › should throw an error if no options are provided
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

169909 passed, 7544 skipped
✔️✔️✔️

Merge workflow run.

sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Oct 18, 2023
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants