-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(chromium-tip-of-tree): roll to r1159 #27605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2a19e21
to
5cf7bd2
Compare
dgozman
approved these changes
Oct 17, 2023
Test results for "tests 1"8 flaky25876 passed, 603 skipped Merge workflow run. |
Test results for "tests 2"2 fatal errors, not part of any test 96 flaky169909 passed, 7544 skipped Merge workflow run. |
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Oct 18, 2023
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by this upstream 4922641: Enable HttpsUpgrades flag by default | https://chromium-review.googlesource.com/c/chromium/src/+/4922641 change.
When this is enabled, https sites will make a
CONNECT
request to our proxy which makes the tests fail. Solution would be to e.g. ignoreCONNECT
requests to indicate that our proxy does not support HTTPS requests (what we did here), alternatively we could disable the flag which would make us not behave like a real Chromium anymore.