[pull] main from microsoft:main #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Speculative fix. The test marked as failed => we reuse the browser without closing the context.
|
No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews. |
👋 Hi there!
|
|
The pull request description is unclear and lacks specific details about the changes made. Please provide a more informative and descriptive summary of the changes. |
Apply Sweep Rules to your PR?
|
Pull Request ReviewHey there! 👋 Here's a summary of the previous results for the pull request review: Changes
Suggestions
Bugs
Improvements
export function getFromCompilationCache(filename: string, hash: string, moduleUrl?: string): { cachedCode?: string, addToCache?: (code: string, map?: any) => void } {
const cache = memoryCache.get(filename);
if (cache?.codePath) {
try {
return { cachedCode: fs.readFileSync(cache.codePath, 'utf-8') };
} catch {
// Not able to read the file - fall through.
}
}
const cachePath = calculateCachePath(filename, hash);
const codePath = cachePath + '.js';
const sourceMapPath = cachePath + '.map';
try {
const cachedCode = fs.readFileSync(codePath, 'utf8');
_innerAddToCompilationCache(filename, { codePath, sourceMapPath, moduleUrl });
return { cachedCode };
} catch {
}
return {
addToCache: (code: string, map: any) => {
if (isWorkerProcess()) {
return;
}
fs.mkdirSync(path.dirname(cachePath), { recursive: true });
if (map) {
fs.writeFileSync(sourceMapPath, JSON.stringify(map), 'utf8');
}
fs.writeFileSync(codePath, code, 'utf8');
_innerAddToCompilationCache(filename, { codePath, sourceMapPath, moduleUrl });
}
};
}RatingRating: 7/10 That's it for the summary! Let me know if you need any further assistance. 😄 |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
`node utils/render_release_notes.mjs js 1.39`
This was missing in focal but was there in Jammy. https://github.com/microsoft/playwright/blob/6b31b30df9edc4c0b64a89ed5c29222ee4dea5a0/utils/docker/Dockerfile.jammy#L44
Also, fix some missing paths in download lists.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Backport to 1.39.X? Fixes #27617
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This fixes: ``` Run npm audit --omit dev # npm audit report @babel/traverse <7.23.2 Severity: critical Babel vulnerable to arbitrary code execution when compiling specifically crafted malicious code - https://github.com/advisories/GHSA-[6](https://github.com/microsoft/playwright/actions/runs/6535308689/job/17744452034?pr=27631#step:10:7)[7](https://github.com/microsoft/playwright/actions/runs/6535308689/job/17744452034?pr=27631#step:10:8)hx-6x53-jw[9](https://github.com/microsoft/playwright/actions/runs/6535308689/job/17744452034?pr=27631#step:10:10)2 fix available via `npm audit fix` node_modules/@babel/traverse 1 critical severity vulnerability To address all issues, run: npm audit fix Error: Process completed with exit code 1. ```
On Linux platforms, specifically check that process.arch is x64, rather than treating it as 'not arm64'. Treat Raspbian's /etc/os-release file as Debian. Document the supported platforms somewhat. Fixes #27453
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This is not referenced anywhere and not getting updated.
This test was failing in Chromium before this change. Caused by https://github.com/microsoft/playwright/blob/40d5e3a3c9957b8d7c22dfc69c4df0789974abc3/packages/playwright-core/src/server/chromium/crInput.ts#L54-L55 which messes up the order of the protocol calls. Fixes #27709.
When merging trace files, we sometimes left open read streams from the zip, which prevents it from being removed. Fixes #27286.
Fixes #27691 Signed-off-by: Max Schmitt <max@schmitt.mx>
…bindings (#27706) **Description** When a language port was using Inspector with the "Locator Picker" feature, it only recognised JavaScript as a language by default. As a workaround the user was able to click record, interact with the page and then the language would be correctly used -> csharp e.g. would work in the "Locator Picker". **Why?** Our language bindings are setting `PW_LANG_NAME=<sdkLanguage>` env var -> good. Our recorder harness also uses this along its internal state here: https://github.com/microsoft/playwright/blob/b9b289b6415515b1b8e1a2524ed6425c8992af5a/packages/playwright-core/src/server/recorder.ts#L369 and it gets used here (no parameter means: we use the first language aka. primary language): https://github.com/microsoft/playwright/blob/b9b289b6415515b1b8e1a2524ed6425c8992af5a/packages/playwright-core/src/server/recorder.ts#L95 The only issue is that the Inspector frontend in the beginning does not know which language it should use and pass over to the server side, it then falls back to JavaScript. **Proposed fix** Instead of passing it over from the frontend to the server side, we just always use it from the server side, aka. "currentLanguage". When the user switches languages in the frontend, "currentLanguage" already gets updated properly via the "fileChanged" event. microsoft/playwright-dotnet#2718 --------- Signed-off-by: Max Schmitt <max@schmitt.mx>
|
Important Review SkippedReviews are disabled for bot users. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
- remove `onlyStartedTests` in favor of explicit branch with comments; - produce one "test not found" error per test instead of a single large error; - extract `_failTestWithErrors` from `_massSkipTestsFromRemaining`.
We saw in the past a lot of users reporting issues like this. Maybe a more readable error helps. Before they just saw: ``` Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'register') at index.38834ec3.js:1:3775 at index.38834ec3.js:1:4006 ``` Fixes #27655
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…27742) Motivation: As of today when a user inspects a Locator which is a xpath, it won't work if the user has not prefixed it with `xpath=` because we internally compare the given with the generated locator. Works: `locator('xpath=//div[contains(@Class, "foo")]')` Does not work: `locator('//div[contains(@Class, "foo")]')` Relates #27707 (comment) Fixes microsoft/playwright-dotnet#2718 (comment) --------- Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Drive-by: - extract `TestErrorView`; - replace `data-test-id` with `data-testid` and `getByTestId()`. --- <img width="1001" alt="top-level errors in html report" src="https://github.com/microsoft/playwright/assets/9881434/2d6c0c52-8df1-46a9-b3fd-06ddc6f16796">
This change assumes that the user has Node 18 with Symbol.dispose available. Fixes #27141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )