Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: break dowload.path() to throw #27662

Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: break dowload.path() to throw #27662

merged 1 commit into from
Oct 17, 2023

Conversation

pavelfeldman
Copy link
Member

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@pavelfeldman pavelfeldman merged commit d4296db into microsoft:main Oct 17, 2023
@commit-lint commit-lint bot mentioned this pull request Oct 17, 2023
Merged
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT
❌ [playwright-test] › reporter-html.spec.ts:705:5 › created › should use file-browser friendly extensions for buffer attachments based on contentType

4 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › components/splitView.spec.tsx:65:5 › drag resize
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

25878 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Oct 18, 2023
@pavelfeldman @sand4rt
chore: break dowload.path() to throw (microsoft#27662)
ee83f94
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@pavelfeldman @Germandrummer92
chore: break dowload.path() to throw (microsoft#27662)
4a9158d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @dgozman